Skip to content

Feat/module test action #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 50 commits into from
Oct 25, 2024
Merged

Feat/module test action #9

merged 50 commits into from
Oct 25, 2024

Conversation

Artlvns
Copy link
Contributor

@Artlvns Artlvns commented Oct 21, 2024

No description provided.

Artlvns and others added 26 commits October 17, 2024 07:49
@Artlvns
New feature terraform test for modules:
86430af 
feat: terraform test action.
feat: matrix for test action.
feat: test report action.
feat: workflow for tf module testing.
@Artlvns
fix: wrong action version
645e2c5
@Artlvns
feat: add icon to report depending on status.
353db7e 
refactor: change some icons.
fix: typo
@Artlvns
fix: remove wrong if condition
ad02af9
@Artlvns
chore: add debug
742c5bc
@Artlvns
chore: debug
4a6cc8b
@Artlvns
feat: add azure login
125023a
@Artlvns
chore: azure login variables
aeb02b9
@Artlvns
fix: az login
7d52d1f
@Artlvns
chore: testing with env
4426820
@Artlvns
fix: add helpers to create-test-report action
6cecea9
@Artlvns
fix: inputs
0e2af1b
@Artlvns
fix: remove result correction as not needed
221654c
@Artlvns
chore: cleanup. chore: add input tf version
5b767fc
@Artlvns
fix: outcome don't fail
7e9636d
@Artlvns
feat: add tflint to pipeline.
05840c3 
docs: update README.md.
@Artlvns
chore: add outcome of lint to report.
85578be 
docs: update README.md with lint step.
@Artlvns
chore: change of flow
ac50918
@Artlvns
chore: add repo as env
d1f2e3a
@Artlvns
feat: plugin cache
ad75e23
@Artlvns
chore: adjustments
ada23e5
@Artlvns
feat: cache
b8556fe
@Artlvns
chore: bump test raport, remove unused fields
818f512
@Artlvns
chore: update test report text
994548b
@Artlvns
fix: typo in comment
78129be
@Artlvns
docs: update README.md
fb1dea5
@Artlvns
Copy link
Contributor Author

Artlvns commented Oct 21, 2024

@Laffs2k5, here is my very first action creation attempt.
Run of terraform-module-ci.yaml workflow looks like this.
Not sure in cache implemented correctly in terraform-module-ci job. Please check. Out from job log - it looks for me OK.
When review passed, new v0 can be released.

One more thing TODO as I see could be merge create-test-report and create-validation-summary actions. Adding more logic could allow to create status table comment depending on workflow, (add or omit some steps) and reusing action. Easiest way to use same logic as I proposed with "Plan" step.

@Artlvns Artlvns requested a review from Laffs2k5 October 21, 2024 12:29
@Artlvns
Copy link
Contributor Author

Artlvns commented Oct 21, 2024

offcourse tf-test tag to be removed after review passed

Laffs2k5
Laffs2k5 approved these changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@Laffs2k5 Laffs2k5 left a comment •
edited by Artlvns
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! I've added a bunch of comments, feel free to ask if anything is unclear.

Remember to:

  • Replace all the TODO tags for testing the actions
  • When merging, maybe a rebase or a squash :-P

Artlvns and others added 23 commits October 25, 2024 09:50
@Artlvns @Laffs2k5
Update .github/workflows/terraform-module-ci.yaml
a0e71c9 
Co-authored-by: Peder Schmedling <24737456+Laffs2k5@users.noreply.github.com>
@Artlvns @Laffs2k5
Update create-validation-summary/action.yml
2bff8db 
Co-authored-by: Peder Schmedling <24737456+Laffs2k5@users.noreply.github.com>
@Artlvns @Laffs2k5
Update .github/workflows/terraform-module-ci.yaml
d8f07a1 
Co-authored-by: Peder Schmedling <24737456+Laffs2k5@users.noreply.github.com>
@Artlvns @Laffs2k5
Update README.md
1967453 
Co-authored-by: Peder Schmedling <24737456+Laffs2k5@users.noreply.github.com>
@Artlvns @Laffs2k5
Update terraform-test/helpers_additional.sh
d811e6a 
Co-authored-by: Peder Schmedling <24737456+Laffs2k5@users.noreply.github.com>
@Artlvns @Laffs2k5
Update terraform-test/action.yml
2d6ab38 
Co-authored-by: Peder Schmedling <24737456+Laffs2k5@users.noreply.github.com>
@Artlvns @Laffs2k5
Update .github/workflows/terraform-module-ci.yaml
bd0d7e6 
Co-authored-by: Peder Schmedling <24737456+Laffs2k5@users.noreply.github.com>
@Artlvns @Laffs2k5
Update create-tftest-matrix/action.yaml
ef19445 
Co-authored-by: Peder Schmedling <24737456+Laffs2k5@users.noreply.github.com>
@Artlvns @Laffs2k5
Update .github/workflows/terraform-module-ci.yaml
df4d3ec 
Co-authored-by: Peder Schmedling <24737456+Laffs2k5@users.noreply.github.com>
@Artlvns @Laffs2k5
Update .github/workflows/terraform-module-ci.yaml
0a025a5 
Co-authored-by: Peder Schmedling <24737456+Laffs2k5@users.noreply.github.com>
@Artlvns @Laffs2k5
Update .github/workflows/terraform-module-ci.yaml
fd3ac81 
Co-authored-by: Peder Schmedling <24737456+Laffs2k5@users.noreply.github.com>
@Artlvns @Laffs2k5
Update .github/workflows/terraform-module-ci.yaml
6424a63 
Co-authored-by: Peder Schmedling <24737456+Laffs2k5@users.noreply.github.com>
@Artlvns @Laffs2k5
Update .github/workflows/terraform-module-ci.yaml
e5ee90d 
Co-authored-by: Peder Schmedling <24737456+Laffs2k5@users.noreply.github.com>
@Artlvns @Laffs2k5
Update .github/workflows/terraform-module-ci.yaml
c3f7e92 
Co-authored-by: Peder Schmedling <24737456+Laffs2k5@users.noreply.github.com>
@Artlvns @Laffs2k5
Update terraform-test/action.yml
7e2e240 
Co-authored-by: Peder Schmedling <24737456+Laffs2k5@users.noreply.github.com>
@Artlvns
Review requested changes:
3a16ab3 
refactor: output variable names to hyphen.
docs: Possible ways to pass inn secrets.
@Artlvns @Laffs2k5
Update .github/workflows/terraform-module-ci.yaml
f31b3fe 
Co-authored-by: Peder Schmedling <24737456+Laffs2k5@users.noreply.github.com>
@Artlvns
chore: requested changes
bf7c702
@Artlvns @Laffs2k5
Update .github/workflows/terraform-module-ci.yaml
bd99501 
Co-authored-by: Peder Schmedling <24737456+Laffs2k5@users.noreply.github.com>
@Artlvns @Laffs2k5
Update .github/workflows/terraform-module-ci.yaml
cb37fa8 
Co-authored-by: Peder Schmedling <24737456+Laffs2k5@users.noreply.github.com>
@Artlvns @Laffs2k5
Update .github/workflows/terraform-module-ci.yaml
4791edd 
Co-authored-by: Peder Schmedling <24737456+Laffs2k5@users.noreply.github.com>
@Artlvns
fix: wrong variable refs in workflow
5caa7aa
@Artlvns
chore: revert dev tag back to v0
d1a4a6d
@Artlvns Artlvns merged commit a168606 into main Oct 25, 2024
@Artlvns Artlvns deleted the feat/module-test-action branch October 25, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Laffs2k5 Laffs2k5 Laffs2k5 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Artlvns @Laffs2k5